src: improve nsolid::CustomCommand() #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevnorris
reviewed
Dec 8, 2023
santigimeno
force-pushed
the
node-v20.x-nsolid-v5.x
branch
from
960cee3
to
367fe4c
Compare
santigimeno
force-pushed
the
santi/custom_command_cb
branch
from
2c87a2c
to
28e2513
Compare
trevnorris
approved these changes
Dec 11, 2023
Make sure `custom_command_proxy_()` is called in every path so there are no potential leaks. Simplify/improve code avoiding unnecessary extra heap allocation for the `req_id`. Added tests covering worker threads and other cases not previously checked. PR-URL: #44 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
santigimeno
force-pushed
the
santi/custom_command_cb
branch
from
28e2513
to
fccddd8
Compare
trevnorris
pushed a commit
that referenced
this pull request
Dec 19, 2023
Make sure `custom_command_proxy_()` is called in every path so there are no potential leaks. Simplify/improve code avoiding unnecessary extra heap allocation for the `req_id`. Added tests covering worker threads and other cases not previously checked. PR-URL: #44 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
trevnorris
pushed a commit
that referenced
this pull request
Dec 19, 2023
Make sure `custom_command_proxy_()` is called in every path so there are no potential leaks. Simplify/improve code avoiding unnecessary extra heap allocation for the `req_id`. Added tests covering worker threads and other cases not previously checked. PR-URL: #44 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure
custom_command_proxy_()is called in every path so there are no potential leaks.Simplify/improve code avoiding unnecessary extra heap allocation for the
req_id.Added a couple more checks to the tests.